Skip to content

fix: replace mimetype with archives - #5228

Merged
soltysh merged 2 commits into
mainfrom
replace_mimetype
Aug 18, 2026
Merged

fix: replace mimetype with archives#5228
soltysh merged 2 commits into
mainfrom
replace_mimetype

Conversation

@brandtkeller

Copy link
Copy Markdown
Member

Description

As discussed in #5140 - we can replace an direct dependency on mimetype with the existing archives direct dependency. mimetype will then become an indirect dependency.

Related Issue

No associated issue

Checklist before merging

Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
@brandtkeller
brandtkeller requested review from a team as code owners August 14, 2026 16:49
@netlify

netlify Bot commented Aug 14, 2026

Copy link
Copy Markdown

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 8351b12
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/6a7f5259dc62d000089fd78a

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.74194% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/packager/pull.go 67.74% 7 Missing and 3 partials ⚠️
Files with missing lines Coverage Δ
src/pkg/packager/pull.go 51.55% <67.74%> (+0.84%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>

@AustinAbro321 AustinAbro321 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@soltysh soltysh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite removal, but definitely move in the right direction for limiting the deps

@soltysh
soltysh added this pull request to the merge queue Aug 18, 2026
Merged via the queue into main with commit a4bfd8a Aug 18, 2026
31 checks passed
@soltysh
soltysh deleted the replace_mimetype branch August 18, 2026 14:43
@github-project-automation github-project-automation Bot moved this to Done in Zarf Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants